bogado / file-line

Plugin for vim to enabling opening a file in a given line
http://www.vim.org/scripts/script.php?script_id=2184
299 stars 61 forks source link

#63: fix for syntax highlighting when opening multiple files on comma… #66

Closed ydeweerdt closed 7 years ago

ydeweerdt commented 8 years ago

I don't know the details of all use cases, but removing the argdo resolves the issue for me.

alberanid commented 8 years ago

I confirm this pull request fixes the problem.

ydeweerdt commented 8 years ago

It is indeed not related to the fix... I probably screwed up my very first pull request... I only wanted one commit to be pulled... Sorry...

On Wed, Sep 21, 2016, 12:49 Jonas Bygdén notifications@github.com wrote:

@jby commented on this pull request.

In plugin/file_line.vim https://github.com/bogado/file-line/pull/66:

    exec (argidx+1).'argument'
  " Manually call Syntax autocommands, ignored by `:argdo`.
  doautocmd Syntax
  doautocmd FileType

endif endfunction

-autocmd VimEnter * call s:startup() +if !isdirectory(expand("%:p"))

If it's not related to the fix, maybe it should be in a separate PR?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bogado/file-line/pull/66, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD78DzsfCV-Y56ZPXPtkbSN8vigWynYks5qsQuhgaJpZM4Gle7J .

bogado commented 8 years ago

No worries, the fix is fine, just remove the unnecessary check and I'll merge it

ydeweerdt commented 8 years ago

can you have a look if it is better now? I just reset my master branch to the single commit holding the fix for #63