bogas04 / SikhJS

👳 🚀 Gurbani Progressive Web Application
https://bogas04.github.io/SikhJS
MIT License
26 stars 16 forks source link

Japuji Sahib doesn't display 'II' #106

Closed plug-n-play closed 7 years ago

plug-n-play commented 7 years ago

Japuji Sahib doesn't displays 'II' marking end of line.

For e.g., following gets displayed,

image

instead of,

image

On installing the Dev-environment locally, along with Gurmukhi fonts, the issue is not reproduced while viewing the markdown conversion in code-editor.

It turns out that the process which converts .md to html removes the character ']' altogether

bogas04 commented 7 years ago

Thanks a lot of raising it, it's actually a known bug. The problem is with new dependency for markdown (snarkdown). For now one quick way to fix it would be to use || over ]], but we might lose out on better glyphs.

If it makes sense to you, we can probably replace all ]] and ] with || and | in a new PR.

bogas04 commented 7 years ago

@plug-n-play Jee. Finally I got free from hectic project at work. I think we can move to some other markdown dependency for now.

bogas04 commented 7 years ago

Switching to remarkable gives us a big hit in bundle size, but we can recover it later.

snarkdown remarkable markdown updated deps with markdown
main.js 87.1 kB
vendor.js 340 kB
main.js 87.1 kB
vendor.js 427 kB
main.js 87.2 kB
vendor.js 362 kB
main.js 87.2 kB
vendor.js 322 kB
bogas04 commented 7 years ago

Fixed by 39b944807d21f11ed8fa41dcf13eaa5fca42d84e