bogaudio / BogaudioModules

Modules for VCV Rack.
Other
268 stars 33 forks source link

VCF cutoff changes when connecting FM input (with FM trim at 0) #205

Closed jamshark70 closed 2 years ago

jamshark70 commented 2 years ago

Here's a very narrow band pass filter with center frequency = 100 Hz.

bogaudio-vcf-disconnected-fm

Here's the same band pass filter, same center frequency set by the knob, but with an LFO connected to the FM input.

bogaudio-vcf-connected-fm

Note that the FM trim knob is set to zero, which I interpret to mean that the FM input signal should have zero effect on the filter frequency.

But the frequency has changed, just by connecting the input.

I would have assumed that the frequency knob sets a baseline value, and 0V in the FM input (whether it's 0V, or trimmed down to 0) would deviate away from that baseline by exactly 0.

This kind of thing is tricky to fix because of backward compatibility -- an unknown number of patches in the wild depend on the current behavior. So it may be unfixable in VCF, but it might be nice to introduce another module.

"FM: an exponential FM input; the input here is attenuated by the FM knob, then added to the V/OCT input (which normals to 0V) before being converted to HZ."

Hm, but, exponential FM should map input 0 onto a frequency ratio of 1, i.e. pow(some_value, volts), and then multiply Hz by this. That is, I guess that 0V is mapping to a positive value (which is necessary for an exponential function) but then being misapplied by addition.

mdemanett commented 2 years ago

Bug confirmed, will look into a fix.

mdemanett commented 2 years ago

This was fixed in v2.1.41.