search

bogaudio / BogaudioModules

Modules for VCV Rack.
Other
268 stars 33 forks source link

S&H: Not normalized to noise #224

Closed ZwergNaseXXL closed 1 year ago

ZwergNaseXXL commented 1 year ago

I'm afraid issue #18 is back in version 2.1.41.

Petervos2018 commented 1 year ago

Are you sure ?

afbeelding

ZwergNaseXXL commented 1 year ago

It didn't work in my patch, even when I duplicated the S&H module and re-initialized it. Now I added a fresh module and it worked. Turns out it's the polyphony setting in the context menu. From GATE input -> works. From IN input -> doesn't work. I'm not even using polyphony, but I think the normalization should work regardless of polyphony or the setting.

mdemanett commented 1 year ago

There was a bug in the poly channels calculation. Thanks for noticing!