Feature: add project-dir as optional argument

bogdaaamn / deta-deploy-action

Simple GitHub Action to deploy current repo to a Deta Micro

https://github.com/marketplace/actions/deploy-to-deta

MIT License

79 stars 17 forks source link

Feature: add project-dir as optional argument #2

Closed joshuanianji closed 3 years ago

joshuanianji commented 3 years ago

Hey @BogDAAAMN, thanks for this action! It's been immensely useful in some of my projects.

This PR adds an optional deta-project-dir argument to the action, which helps in some cases (esp. monorepos) where the Deta code is in a folder. Let me know if it looks good!

bogdaaamn commented 3 years ago

Heyy @joshuanianji! That's a very good idea, I remember seeing your fork and thinking that it would be nice to be part of the action 😂

Thanks a lot for the PR! Writing the spec and merging.

joshuanianji commented 3 years ago

No problem, thanks for responding so quickly! This is actually based off of @MatyiFKBT's fork, but it didn't seem like they were going to be creating a PR anytime soon.

Nonetheless, I'm glad to be part of the action 😆 .

MatyiFKBT commented 3 years ago

thanks for the PR @joshuanianji, I started working on this but haven't got time to create one myself.