Add i18n inheritance. - Githubissues

bogdan / datagrid

Gem to create tables grids with sortable columns and filters

MIT License

1.02k stars 116 forks source link

Add i18n inheritance. #201

Closed pudiva closed 7 years ago

pudiva commented 7 years ago

allows grid subclasses to use translations from superclasses. also take scope.klass.human_attribute_name() into account when translating columns.

it works, but wasn't tested that much yet...

pudiva commented 7 years ago

EHLO wat do u think of this? <3

bogdan commented 7 years ago

Sorry, I am currently on vacation. I can review in depth some time next week. In the meanwhile, can you add some tests and make the build green?

pudiva commented 7 years ago

sry im in a hurry right now! btw im not using datagrid anymoar =o(. even though teh patch kinda worked, i need more flexibility than datagrid can offer. ill share my discoveries ASAP! <3

bogdan commented 7 years ago

The alternative version was merged to master. Thanks.