Avoid calling filters instance method prematurely

[banhill]

I propose this change to avoid calling an instance method on a not completely initialized object. More precisely to fix the case when an if or unless condition references an attribute that hasn't been set yet.

module RoleDependant
  extend ActiveSupport::Concern

  included do
    attr_accessor :role

    delegate :admin?, to: :role
  end
end

class FooGrid
  include Datagrid, RoleDependant
  ...
  filter(..., if: :admin?)
end

FooGrid.new(role: some_role)

This gives a NoMethodError, because role is nil, when enabled? is evaluated.

[bogdan]

Can you add a test?

[banhill]

Sure, I'll write it in the next couple of days.

Btw the build failure for ruby v2.4.0 is sporadic and can also be reproduced on master.

[bogdan]

Released 1.5.3 with the patch. Thanks.

[banhill]

No problem, glad I could help.