bogdan / datagrid

Gem to create tables grids with sortable columns and filters
MIT License
1.02k stars 115 forks source link

batch_size default #276

Closed dgodd closed 4 years ago

dgodd commented 4 years ago

In generating a CSV file which is foolishly large using datagrid, I discovered the batch_size class accessor. It appears to me that the docs specify that it has a default of 1000 (https://github.com/bogdan/datagrid/blob/master/lib/datagrid/columns.rb#L36) but that in reality the default is nil.

Assuming I am correct, I'm happy to submit a PR to either the docs or to set the default to be 1000.

bogdan commented 4 years ago

Yes, lets fix that and add a test.