Closed fabriciofreitag closed 2 years ago
Valid point: you may submit a PR or I'll fix it some time next week.
After considering that, I am not so convinced about deep_merge
here.
The order should be applied to the grid that is currently displayed on the page no matter what are URL parameter, so if url parameters has grid[k1]=v1
but the grid being displayed on the page has grid[k1]=v2
the resulting URL for ordering the grid should have grid[k1]=v2
not v1
because for the user the grid he asked to be ordered is the one having v2
.
Having an URL like such:
Will ultimately generate order links (through
datagrid_order_path
) without the parameters nested within theadmin_customers_grid
key.The solution to that (I believe) would be to change this to use
deep_merge
instead ofmerge
.