Commit c646a33 introduced a bug in pull-ups

bogde / HX711

An Arduino library to interface the Avia Semiconductor HX711 24-Bit Analog-to-Digital Converter (ADC) for Weight Scales.

MIT License

876 stars 535 forks source link

Commit c646a33 introduced a bug in pull-ups #232

Closed nschurando closed 2 years ago

nschurando commented 2 years ago

Commit c646a33 introduced a bug, where for non espressif board the input will not be set to pullup. Line 64 of HX711.cpp should be #if and not #ifdef.

https://github.com/bogde/HX711/blob/f006854653eab557fb5f3d51d4605e145e377478/src/HX711.cpp#L64

bogde commented 2 years ago

Should be fixed in be5e3d251b0aa6c1279edf76ab985825de4ebfd9.