search

bogenpirat / remote-torrent-adder

A handy Chrome extension to add torrent files to torrent clients
237 stars 81 forks source link

Updated to support the newer API in 4.2.0 #254

Closed gbonk closed 5 years ago

gbonk commented 5 years ago

This is in response to my Ticket #253

I hope you like it

bogenpirat commented 5 years ago

alright, thank you for your work, the changes by themselves look okay, but i've got two points.

first, api v2 was first implemented in qbt 4.1.0 according to the description of this python package (information which was remarkably hard to find) in May of 2018.

currently, qbt 4.1.7 is stable.

i'm willing to wager that people on average are VERY lazy about updating their torrent clients, so overwriting the previous implementation with this one would leave people with qbt <4.1 (which does not use the v2 api) stranded. for this reason, i'd prefer for this to become its own, separately selectable client.

secondly, this commit removes support for magnet links. that's not good, because people might be using it.

your PR is quite old by now (apologies for that), and i'll be pulling your commits into a separate branch to work on some changes to them relating to above points. again, thank you for your work.

bogenpirat commented 5 years ago

i apologize, i just noticed they put together the magnet/file upload torrent adding methods into one endpoint. works fine.