search

bogosj / tesla

Provides a wrapper around the API to easily query and command a Telsa car.
Other
22 stars 18 forks source link

fix unmarshalling of /products endpoint via custom type #118

Closed GrimmiMeloni closed 9 months ago

GrimmiMeloni commented 10 months ago

fix #117

GrimmiMeloni commented 10 months ago

@andig would you mind reviewing?

GrimmiMeloni commented 10 months ago

I am completely puzzled by the issue reported by golangci-lint. It is clearly a false positive, but I don't understand why the same flow works locally when executed via act.

andig commented 9 months ago

Just dont use dot imports?

GrimmiMeloni commented 9 months ago

Just dont use dot imports?

That's of course one way to solve this. However the dot import style is also used by the other tests in the project, and mores this is also how the authors of convey show this in their docs. At the end of the day, the code style part for sure is arguable. What's more odd though is that the linter claims an unused import, although that's incorrect. But I will cut my losses here, and just adjust accordingly.