search

bogosj / tesla

Provides a wrapper around the API to easily query and command a Telsa car.
Other
23 stars 18 forks source link

Stop returning an always-nil error in NewClient. #23

Closed bogosj closed 3 years ago

bogosj commented 3 years ago

Addresses one note in https://github.com/bogosj/tesla/issues/16

uhthomas commented 3 years ago

I'm wary of having this fixed API. Although not perfect, I like to use Google's Go APIs as a guideline as it seems to scale well. They make use of functional options which Dave Cheney gives a good talk on. I'm using this pattern on the other project here.

Let me know your thoughts.

bogosj commented 3 years ago

Yes, agreed. I discussed offline with @michaelharo, I'm going to close this PR and update the #16