search

bogosj / tesla

Provides a wrapper around the API to easily query and command a Telsa car.
Other
23 stars 18 forks source link

Remove Streaming API as it is currently broken. #45

Closed bogosj closed 3 years ago

bogosj commented 3 years ago

Fixes #44.

uhthomas commented 3 years ago

The Tesla API is in a really sad state at the moment. Not sure why they're being so anti developer.

Maybe better for a GitHub discussion rather than a PR comment, apologies.

I think this change is fine but what happens when (if) it eventually works again? I don't know if we should remove code because the upstream isn't working correctly.

bogosj commented 3 years ago

If there's someone who wants to consume the streaming bits, they can revert the change that I note in the README, ensure it's working again, and we release that?

bogosj commented 3 years ago

Also presumably the streaming API does work - I'm fairly confident that teslamate is using it to record data.

mark-sch commented 3 years ago

In my eyes the streaming api is pretty valueable - due to all the phantom drain problems when waking up the vehicle. Teslamate is using wss://streaming.vn.teslamotors.com/streaming/ for their streaming ...would like to contribute during work in progress but right now not long enough into golang to do it from scratch completely

bogosj commented 3 years ago

@mark-sch The proposal here is not to permanently remove this wrapper, but since it's broken in its current state we temporarily "hide" it by deleting it for now until someone who does use it has time to work on it and we can release a working version.

andig commented 3 years ago

How about just parking these files in an internal folder and hence making them inaccessible from the outside world? I intend to look into this, but no ETA.

bogosj commented 3 years ago

I'd prefer to leave this as is - moving to an internal folder would require modifying the deleted files so that tests keep passing. As it is to get this back to work on in we'll just have to git revert <insert_commit> and everything will be back to the way it was before. Moved to internal you'd have to tweak the tweaks made to the files.

bogosj commented 3 years ago

Just in case it was missed above, an immediate follow up commit will write notes in the README in the root about the lack of the streaming API and pointing at the commit this PR creates.

bogosj commented 3 years ago

https://github.com/bogosj/tesla/commit/f9b53076da5eed2afe1b77f8ea2f6ad0a3664815