search

bogosj / tesla

Provides a wrapper around the API to easily query and command a Telsa car.
Other
23 stars 18 forks source link

Add function on vehicle to create a command URL #62

Closed bogosj closed 3 years ago

bogosj commented 3 years ago

This cleanup resolves #35.

bogosj commented 3 years ago

Hold off on reviewing, I'm going to re-do the tests with Convey.

bogosj commented 3 years ago

PTAL

andig commented 3 years ago

Cumbersome: https://stackoverflow.com/questions/34668012/combine-url-paths-with-path-join

bogosj commented 3 years ago

Cumbersome: https://stackoverflow.com/questions/34668012/combine-url-paths-with-path-join

Indeed that method seems unnecessary, I'm fine leaving this with strings.Join

bogosj commented 3 years ago

Ping @michaelharo, this look good for now?

michaelharo commented 3 years ago

Ping @michaelharo, this look good for now?

I'm fine with this for now.