Added snow sounds - Githubissues

bogstandard / rl-weather

Weather plugin for RuneLite

BSD 2-Clause "Simplified" License

9 stars 3 forks source link

Added snow sounds #15

Closed ipkpjersi closed 1 year ago

ipkpjersi commented 1 year ago

This closes #14

bogstandard commented 1 year ago

Nice one thanks, I'll test & hopefully merge this soon!

The other sounds work for you then? For me the sound effects are broken in the production build, see #6 . Maybe this is a MacOS vs Windows bug.

ipkpjersi commented 1 year ago

So the sounds don't work for me on stable RL, but I usually run it from an IDE anyway where the sounds do work. I'm on Linux, here's the stacktrace from RL stable:

We could probably replace the built-in sound player with an MP3 sound player or something similar, and then we'd be able to gain stuff like volume controls (we could have a percentage config option in the settings menu).

I'm hoping I'll have time to work on that at some point, but I didn't have time this weekend unfortunately.

bogstandard commented 1 year ago

Thanks, if you're able to offer any help it's very much appreciated. I'm fairly busy too so I'm unlikely to be able to get to it either lol. Anyway; this and #16 are now merged into Master and awaiting the RL Hub maintainers to merge the changes (see https://github.com/runelite/plugin-hub/pull/3655).

Summary of changes I've made on these two:

Bumped RuneLite version so plugin builds.
Moved from creating a new Gson instance to Inject'ing the Gson, as demanded by RL's CI rules. Similar to how the OKHttp stuff works.