search

bogstandard / rl-weather

Weather plugin for RuneLite
BSD 2-Clause "Simplified" License
9 stars 3 forks source link

Possibly fixed sound playing on RL non-dev #18

Closed ipkpjersi closed 1 year ago

ipkpjersi commented 1 year ago

This seems to have fixed playing sound, at least for me on Linux, since it no longer runs an unnecessary mark/reset test.

It's still worth switching from default audio playback provided by Java to an actual library that can handle more advanced features like setting volume level, etc but this might be a suitable fix for now.

This probably closes #6

ipkpjersi commented 1 year ago

@bogstandard Did you manage to have a look at this? Does this fix the sound issue for you?

bogstandard commented 1 year ago

Not had a look yet, hoping to squeeze in time after work this week before Christmas really hits my schedule.

But.. I've no way of knowing whether this is a true fix for me, since the bug only occurs for me in the build that gets put up on Plugin Hub.. unless there's some obvious way to reach that build with my IDE? (Java compiling and building baffles me a bit)

ipkpjersi commented 1 year ago

Honestly, I'd say it's a simple enough change that it'd probably be worth just pushing it up as-is and seeing how that goes for everyone, especially since sound is an opt-in feature that already doesn't work, it's not like it could break any more than it already is lol

Just my two cents on it, I'm not 100% sure on further testing it either since I'm still fairly new to RL plugins myself.

bogstandard commented 1 year ago

oops there is actually a bug with this, the sounds don't stop on close. Working on a patch now.

ipkpjersi commented 1 year ago

Wait what do you mean don't stop on close? Sounds successfully stop for me when disabling specific sounds, or turning sounds off entirely, or turning the plugin off entirely, or closing out of the client.

Is there a specific set of steps you take so I can replicate the issue?

bogstandard commented 1 year ago

Eh, must've been a funny turn on my version. Testing again I can't replicate it and I'm happy with how the code looks. My Java instances are always a bit funny on this machine 😅, forgive me.

That's all the PRs merged now I think, I'll wait until the Plugin Hub maintainers update the current pending request then I'll submit these latest changes as a new one. I think they don't like it if you change something they're actively reviewing.