search

boguszpawlowski / ComposeCalendar

A Jetpack Compose library for handling calendar component rendering.
Apache License 2.0
318 stars 39 forks source link

Week mode #89

Closed andrey-ananiev closed 1 year ago

andrey-ananiev commented 1 year ago

I added a weekly mode to the calendar. Closes #39

boguszpawlowski commented 1 year ago

Hi @andrey-ananiev. Thank you for your contribution! I'm a little short on time right now, but I should be able to review this on the weekend. Until then, please make sure that Detekt is passing and run ./gradlew apiDump to generate new API scheme.

andrey-ananiev commented 1 year ago

Hi. I don`t know how I can retate the Detect Check. I am new to github.

boguszpawlowski commented 1 year ago

Hi. I don`t know how I can retate the Detect Check. I am new to github

@andrey-ananiev If you have a mac, you can run ./gradlew detekt (or gradlew detekt on Windows) locally in a terminal in project directory. This should show you all the errors from detekt.

boguszpawlowski commented 1 year ago

@andrey-ananiev I have implemented something similar, using 2 separate composables, would be grateful if you would take a look and tell me what do you think about it: https://github.com/boguszpawlowski/ComposeCalendar/pull/91 Personally, I think this will be much easier to maintain in the future and the resulting code is much more readable.

andrey-ananiev commented 1 year ago

@andrey-ananiev I have implemented something similar, using 2 separate composables, would be grateful if you would take a look and tell me what do you think about it: #91 Personally, I think this will be much easier to maintain in the future and the resulting code is much more readable.

Thank you for supporting the weekly calendar idea. I will definitely look at your implementation and give feedback.

boguszpawlowski commented 1 year ago

@andrey-ananiev Thank you for your contribution, but I will be going with the second pr.