Added switch for displaying meta image in header

boh717 / beautiful-ghost

Theme for Ghost blogging platform

MIT License

36 stars 20 forks source link

Added switch for displaying meta image in header #3

Closed dinchamion closed 7 years ago

dinchamion commented 7 years ago

I believe I kept the rest generic as they should be. What I changed:

in partials/header_post_page.hbs there is now a switch between showing the meta image as header or not. Default is showing.
Added meta tags to partials/head.hbs: I've tested on multiple sites, and all values are generated from the blog settings, nothing specific is hard-coded. ;-)

Other changes in the files are due to me reverting to the originals and because I'm new to this. :-)

boh717 commented 7 years ago

At first glance it looks OK. I'll review it during the week-end :)

Did you test if it works?

dinchamion commented 7 years ago

Yes I did :-) All embeds pull the meta information and image properly, and the browser console is clean as a whistle too. (The latter took some doing :-) )

Running it on dinchamion.com :-) (And loving it, awesome job on the theme!)

boh717 commented 7 years ago

@dinchamion I didn't forget to merge, I simply had no time! I'll do it ASAP :)

dinchamion commented 7 years ago

@boh717 take your time, there's no rush ;-)