search

bohoomil / fontconfig-ultimate

freetype2-infinality run-time settings => infinality compatible fontconfig => infinality-bundle
454 stars 38 forks source link

Upstream source compatibility improvements #104

Closed goddesse closed 9 years ago

goddesse commented 9 years ago

Build with _GNU_SOURCE for strcasestr and strcasecmp Use freetype2's new header file macros where possible

bohoomil commented 9 years ago

Thank you very much!

goddesse commented 9 years ago

Is #98 still a problem for you with this build? If so, can you point me to an SVG that crashes still?

bohoomil commented 9 years ago

Unfortunately, yes, nautilus still crashes with SVG files. I used the one provided in #81, Keller-Raumschild.svg, for tests.

BTW, nemo is also affected.

goddesse commented 9 years ago

Well, that's a bit unfortunate. I can install an older release on Fedora 22 that wasn't built with _GNU_SOURCE and immediately get the crash, but once I install the most recent package and login again to make sure the new freetype-infinality is loaded, I can no longer repro the crash.

I'll install Arch in a virtual machine later this evening and hopefully I can repro it. Can you look through the build output and see if you're getting complaints about an implicit strcasecmp and strcasestr from GCC?

bohoomil commented 9 years ago

No: strcasecmp and strcasestr complaints appeared in the previous build(s), before I applied your patches.

vcunat commented 8 years ago

This caused me problems when compiling for windows, as there's apparently no strcasestr available. (Details: I'm cross-compiling linux->mingw.)

vcunat commented 8 years ago

Perhaps it would be better to use standard functions instead. But personally this edge case of mingw+infinality isn't important to me; I just stumbled on it and avoided it by not using infinality.