search

bohoomil / fontconfig-ultimate

freetype2-infinality run-time settings => infinality compatible fontconfig => infinality-bundle
454 stars 38 forks source link

custom_postjob() in fc-presets #151

Closed BubuXP closed 8 years ago

BubuXP commented 8 years ago

I'm trying to package infinality-ultimate for Debian. I don't understand well code in general, but while checking it I found the following in fc-presets.

row 196 is ln -s ../conf.avail.infinality/35-repl-custom.conf . 2>/dev/null shouldn't it be ln -s $presets_dir/35-repl-custom.conf $config_dir 2>/dev/null

and also row 192 if [[ $check_current == *combi* ]] && [[ -f ./35-repl-custom.conf ]]; then shouldn't it be if [[ $check_current == *combi* ]] && [[ -f $config_dir/35-repl-custom.conf ]]; then

bohoomil commented 8 years ago

Yes, there should be variables. Thanks for taking your time and tracking it down.

BubuXP commented 8 years ago

Very fast response, thank you. But maybe you forgot something. It's now: ln -s $presets_dir/35-repl-custom.conf . 2>/dev/null but it should be: ln -s $presets_dir/35-repl-custom.conf $config_dir 2>/dev/null right?

bohoomil commented 8 years ago

Probably like this would be better:

ln -s $presets_dir/35-repl-custom.conf $config_dir/35-repl-custom.conf 2>/dev/null

Edit I uploaded a fixed version, please check it out.

BubuXP commented 8 years ago

I didn't answer because it was ok, but it works even without repeating the file name, as the link will retain the same name.

I found another row (180) with a similar syntax. It's: ln -sf $target . better: ln -sf $target $config_dir

bohoomil commented 8 years ago

Thanks for the feedback. I'm not on Linux right now but as soon as I'm, I'll fix the line.