search

bohua / nprinting-sense-on-demand

NPrinting On-demand extension for Qlik Sense
MIT License
10 stars 13 forks source link

added possibility to use nprinting server on different host #21

Closed and29 closed 5 years ago

and29 commented 5 years ago

Fix of the following issues:

GINQO commented 5 years ago

Hi Andrea,

Just wondering why you might have closed this update, it seems like just the thing I need for one of our setups. Did you run into any issues that prevented this technique from being effective?

Thanks, GINQO

and29 commented 5 years ago

Hi GINQO,

this version is closed because it works in an environment but it doesn't in another. I still didn't figure it out why, that's why I was waiting to reopen it. But I think you can use it.

Thank you, Andrea

GINQO commented 5 years ago

Thank you, sir, & thanks for your effort on the project...

Cheers, GINQO

GINQO commented 5 years ago

Actually, I did come across something in my travels while reading up on CORS that might be useful: it sounds like it is the responding server (e.g. NPrinting) that needs to apply the Access-Control-Allow-Origin header, the request needs to provide the Origin header (which is matched by the browser against the Access-Control-Allow-Origin), so I'm not sure if this code change would have the desired effect (as it is applying the Access-Control-Allow-Origin to the request & not the response).

and29 commented 5 years ago

You are right! I did it because I was having CORS error and I learned later what you just explained. I'll remove them and push the changes on my fork. Thank you! Andrea

bohua commented 5 years ago

Hi Andrea,

Sorry for a late reply. Just back from vacation.

I think it’s a mistake action when I cleaning the repo. I will recover it. :)

Thanks a lot for your contribution! //Bohua

On Nov 15, 2018, at 3:41 PM, Andrea Mauro notifications@github.com wrote:

Closed #21 https://github.com/bohua/nprinting-sense-on-demand/pull/21.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bohua/nprinting-sense-on-demand/pull/21#event-1968823908, or mute the thread https://github.com/notifications/unsubscribe-auth/ADQoL0wheu-i6glOYe41GXLvHug0z8aMks5uvX0jgaJpZM4YCBlp.

and29 commented 5 years ago

Hi bohua, thank you for the extension!

GINQO commented 5 years ago

Yes, indeed, thank you, Bohua!