boidushya / better-lyrics

Better Lyrics for Youtube Music - Enhance YouTube Music with beautiful time-synced lyrics, multilingual support, real-time translations and more ✨
https://better-lyrics.boidu.dev
GNU General Public License v3.0
71 stars 6 forks source link

Not showing anymore the message if a song doesn't have lyrics #23

Closed Tortillas-IT closed 2 months ago

Tortillas-IT commented 2 months ago

After: Schermata_20240619_184848 Hi, i see you updated your exstension to not show for a bit the static lyrics before showing the live one. So this causes the message that a song doesn't have lyrics to not appear.

Before: Schermata_20240619_185115 This should be an easy fix, great work about this fantastic exstension, thanks :D

NOT RELATED: Btw i saw you on a thread about the project "Youtube Music Desktop App", thanks to give permission to other devs to use your code, this is what i love about open source community :) thanks

boidushya commented 2 months ago

Thats odd, are you on the latest version? v1.5.4? I tried it for the same song and i see the lyrics

image

NOT RELATED: Btw i saw you on a thread about the project "Youtube Music Desktop App", thanks to give permission to other devs to use your code, this is what i love about open source community :) thanks

Thank you!

Tortillas-IT commented 2 months ago

Thats odd, are you on the latest version? v1.5.4? I tried it for the same song and i see the lyrics <img alt="image" width="1512" src="https://private-user-images.git

NOT RELATED: Btw i saw you on a thread about the project "Youtube Music Desktop App", thanks to give permission to other devs to use your code, this is what i love about open source community :) thanks

Thank you!

That's "All of The Lights (Interlude)" not "All of The Lights"!!

boidushya commented 2 months ago
image

Ah here's the screenshot of All of the lights interlude on v1.5.5

Tortillas-IT commented 2 months ago

Ah here's the screenshot of All of the lights interlude on v1.5.5

I don't see that message, it's just blank. Could it be a localization issue? (I have the latest version, 1.5.5)

NOT RELATED: Btw do you like the new playlist interface? I love it, feels so fresh

boidushya commented 2 months ago

Could it be a localization issue?

I doubt it, what do your logs say? Browser console i mean?

Btw do you like the new playlist interface? I love it, feels so fresh

Dont think i got the update 😅

Tortillas-IT commented 2 months ago

Could it be a localization issue?

I doubt it, what do your logs say? Browser console i mean?

Btw do you like the new playlist interface? I love it, feels so fresh

Dont think i got the update 😅

Schermata_20240621_190552

boidushya commented 2 months ago

That's super odd, but i cant seem to repro it. I'll keep this issue open in case anyone else faces this

boidushya commented 2 months ago

Should be working properly in the latest release! v1.5.9 lmk if it doesn't 🤝

Tortillas-IT commented 2 months ago

Checked on 1.5.10 and still having the same issue, please reopen this issue

boidushya commented 2 months ago

Checked on 1.5.10 and still having the same issue, please reopen this issue

Can you give me the repro steps? Its working for me with the song you provided.

Tortillas-IT commented 2 months ago

Checked on 1.5.10 and still having the same issue, please reopen this issue

Can you give me the repro steps? Its working for me with the song you provided.

As usually, play a song without lyrics and then go to lyrics tab, I tested with "All of the Lights (Interlude)"

boidushya commented 2 months ago

Checked on 1.5.10 and still having the same issue, please reopen this issue

Can you give me the repro steps? Its working for me with the song you provided.

As usually, play a song without lyrics and then go to lyrics tab, I tested with "All of the Lights (Interlude)"

The issue is I've tried pretty much all possible ways and i always get the No Lyrics Found text.

https://music.youtube.com/watch?v=v4QrSWRT5qI&list=OLAK5uy_lUlpor68rM1s9pkNM-8fNJRstJI5AsPWo

image

I'm afraid I can't reopen this issue till I get some concrete steps to reciprocate this behaviour.

Tortillas-IT commented 2 months ago

Checked on 1.5.10 and still having the same issue, please reopen this issue

Can you give me the repro steps? Its working for me with the song you provided.

As usually, play a song without lyrics and then go to lyrics tab, I tested with "All of the Lights (Interlude)"

The issue is I've tried pretty much all possible ways and i always get the No Lyrics Found text.

https://music.youtube.com/watch?v=v4QrSWRT5qI&list=OLAK5uy_lUlpor68rM1s9pkNM-8fNJRstJI5AsPWo

I'm afraid I can't reopen this issue till I get some concrete steps to reciprocate this behaviour.

I'm not at my PC rn, gonna check further later

Tortillas-IT commented 2 months ago

Console output: Schermata_20240626_180703

Exstension settings: Schermata_20240626_180731

boidushya commented 2 months ago

Can you please drop the link to this song? there seems to be multiple versions of it (and all of them seem to work for me with the same settings...)

Tortillas-IT commented 2 months ago

Can you please drop the link to this song? there seems to be multiple versions of it (and all of them seem to work for me with the same settings...)

https://music.youtube.com/watch?v=WHxRd_va950&si=vfw2XGxKHZK8StdA

The one fron the album ;-;

boidushya commented 2 months ago

Yea man this is incredibly odd, i just don't get this error, might have to do with youtube music having some kind of AB testing with their UI layout which messes with the selectors.

Tortillas-IT commented 2 months ago

I tried to reproduce the issue on my windows 11 partition and i'm getting the same issue there, too