search

boidushya / better-lyrics

Better Lyrics for Youtube Music - Enhance YouTube Music with beautiful time-synced lyrics, multilingual support, real-time translations and more ✨
https://better-lyrics.boidu.dev
GNU General Public License v3.0
71 stars 6 forks source link

💡 [REQUEST] - User feedback/suggestions on timestamps #35

Open i-am-zaidali opened 1 month ago

i-am-zaidali commented 1 month ago

Summary

I'm not good at titles so here's a detailed explanation: Some songs on yt music aren't actually uploaded as music but rather as full length videos and often have extra parts at the start and/or the end of the video. This messes the lyrics synchronization up since the extension has no way to account for that. I propose allowing users to suggest timestamps where the song actually starts and ends, and if there are breaks in the middle, much like how sponsorblock works with community contributions. I am not really sure how you would be able to handle that in the backend but perhaps have a database where user suggestions for the music URL are stored along with the timestamps and then when the video/music plays, you don't start the synchronization until the suggested timestamp in the video comes.

If you agree to this and could guide me a bit around on how you would want to implement it, I'd be able to help create a PR that implements this.

Looking forward to your response.

Basic Example

A basic example, from where I thought of this feature, is eminem's fall song from kamikaze that has an MV and the lyrics are all out of sync by a lot. https://music.youtube.com/watch?v=MfTbHITdhEI

Reference Issues

No response

Unresolved questions

No response

Would you like to work on this feature?

boidushya commented 1 month ago

Hey! This is a great request as a lot of other people have been having a similar issue.

The backend is written in Go and you can find it here https://github.com/boidushya/better-lyrics-api/tree/ed4a2461b50b650073d829ad2de445951bd60a14

This is a pretty substantial task so let me know if you need any help navigating the codebase

For backend env variables, you can find out how to contact me through here or reach out to me via Discord boidu.

elvis88688 commented 1 month ago

Hi, here's a suggestion, maybe you can provide a function that user can modify the time themself, and save the timestamps locally. Sorry for the bad English.