search

boinkor-net / governor

A rate-limiting library for Rust (f.k.a. ratelimit_meter)
https://github.com/boinkor-net/governor
MIT License
579 stars 45 forks source link

Fails to build on x86 without SSE2 due to outdated quanta dep #178

Closed wez closed 1 year ago

wez commented 1 year ago

This is the underlying issue:

surfaces over in:

Please consider updating to a current version of quanta

antifuchs commented 1 year ago

Known bug (#174), addressed in #175, which unfortunately is not straightforward: There's a 50% perf regression in our quanta-based benchmarks that I haven't been able to track down yet.

If you want to quickly fix this, pull in governor without default features & leave out the quanta feature; that should compile it with std::time::Instant as the default clock.

Separately, I'm surprised: is this crate working on x86? I thought due to the use of AtomicU64 in #89, this crate doesn't work on non-64bit platforms.

wez commented 1 year ago

Thanks; I already found that I can omit the quanta feature.

re: 32-bit systems, I don't know how/if it works. I was passing on a build failure from @kekePower who is packaging wezterm for the Mageia distribution. Apparently with quanta removed (only the std feature enabled) it compiles, so it should work?