Open jmfrank63 opened 8 months ago
It looks like the issue was transient. Today it worked and exposed my first test I added did not succeed in covering a failure of compare_exchange_weak. But the second did. However, this failure of coverage only appeared after the rebase and the tests are not easy to write. I cannot keep this up indefinitely. These tests are by no means easy to write. The coverage is now back to 100% and overall has actually increased. I think the branch should be merged now. I leave the issue open, until you decide if this can be merged or should be rejected. With your decision taken, feel free to close the issue.
This error is only shown in the
codecov
report, but leads to the test actually succeeding.This might be intended or not critical, I cannot judge this. Please have a look at PR 146. I did not change any tests, but added one to cover three lines in
in_memory.rs
. The test seems to be covering the lines if I check for coverage locally, but I cannot verify it online.If you think the PR is fine and the error is marginal, I'd appreciate merging it.