search

boiscljo / SBA

An addon to ScreamingSandals bedwars plugin to hypixelify it!
GNU General Public License v3.0
20 stars 14 forks source link

PerWorldPlugins compatibility #9

Closed TonimatasDEV closed 1 year ago

TonimatasDEV commented 1 year ago

My PerWorldPlugins is fully compatible, I have compiled your plugin without the PerWorldPlugins fix and it worked perfectly, as I know there are more PerWorldPLugins, the only thing I have done is that if it detects that the author is me, it should not be disabled.

TonimatasDEV commented 1 year ago

The newest versions of my PerWorldPlugins don't use injectors and use other system.

boiscljo commented 1 year ago

I'll test it tomorrow, in the meantime can you change the message in the error to redirect users to update PerWorldPlugins instead of removing it.

boiscljo commented 1 year ago

I wasn't able to reproduce the compatibility with PWP 1.1.4. From what I see, SBA still doesn't receive the BedwarsGameStartedEvent event, if it worked this villager would be an NPC image and the shop would have prices image

Please make sure SBA receives that event and returns to this PR once it will be fixed @TonimatasDEV

Attaching some pictures of how it should be if SBA worked with PWP installed.

image image