ColumnDataSource.data field should not use Any

bokeh / bokeh-scala

Scala bindings for Bokeh plotting library

MIT License

135 stars 16 forks source link

ColumnDataSource.data field should not use Any #5

Closed mattpap closed 8 years ago

mattpap commented 9 years ago

We use type class-based serialization method (through play-json) and Any doesn't play well with this approach. Using HList from shapeless is one option. I tried this once, but failed.

mattpap commented 8 years ago

Switched from Any to JsValue. This is mostly invisible to the user, because one will use column() macro anyway, which hides raw JSON and is fully type safe.