This commit does not run pre-commit on the repo, it just adds it as a dev dependency, and adds the following checks.
prevents commits to the main branch
remove unused imports from python files
modifies all imports to be absolute for python files
removes commented out code in python files
runs isort on imports for python files
runs black on python files (formatting)
runs ruff on python files (linting)
fixes for the setup.cfg file
ensures json, yaml, and toml files are parseable (ignores the conda.recipe/meta.yaml file)
uses local installs of eslint and prettier for linting and formatting any [java|type]script files.
Also, three additional files have been added.
ipywidgets_bokeh/.eslintrc.js
ipywidgets_bokeh/.prettierrc
These files contain the formatting and linting rules as outlined in Bokeh.
The last file is a project.toml file that for the time being only contains preferences for ruff. In the future we can use it for complying with setuptools installs.
The package*.json files have also been modified to include eslint and prettier, as well as updating the lint script from a TODO to an actual linting action. This helps with the requests in #75
philippjfr
commented
1 year ago
This commit does not run pre-commit on the repo, it just adds it as a dev dependency, and adds the following checks.
mainbranchisorton imports for python filesblackon python files (formatting)ruffon python files (linting)setup.cfgfilejson,yaml, andtomlfiles are parseable (ignores the conda.recipe/meta.yaml file)Also, three additional files have been added.
ipywidgets_bokeh/.eslintrc.jsipywidgets_bokeh/.prettierrcThese files contain the formatting and linting rules as outlined in Bokeh.
The last file is a
project.tomlfile that for the time being only contains preferences forruff. In the future we can use it for complying withsetuptoolsinstalls.The
package*.jsonfiles have also been modified to include eslint and prettier, as well as updating thelintscript from aTODOto an actual linting action. This helps with the requests in #75Resolves #80