search

bokeh / ipywidgets_bokeh

Allows embedding of Jupyter widgets in Bokeh applications.
BSD 3-Clause "New" or "Revised" License
24 stars 11 forks source link

Remove unused webpack.ts #96

Closed ndmlny-qs closed 1 year ago

ndmlny-qs commented 1 year ago

src/webpack.ts is not used, and is removed in this commit.

The following files

have been modified to remove commented out code, and fixes a few != and == where they should be !== and ===.

mattpap commented 1 year ago

This code actually seems to be doing something.

Before this PR: image

and after: image

The warnings in the before image are the doing of my PR #95.

ndmlny-qs commented 1 year ago

thanks for showing this does something. do you know why it is using these fonts? I don't fully understand why a wraper would need fonts, but I'll close it out

mattpap commented 1 year ago

I think fonts are used for icons in ipyvolume's toolbar, which is currently broken regardless (it's actually sort of present in Firefox). I would be happy to get rid of this code, but I suppose there will be another mechanism necessary to load resources like fonts.