search

bokeh / jupyter_bokeh

An extension for rendering Bokeh content in JupyterLab notebooks
BSD 3-Clause "New" or "Revised" License
249 stars 48 forks source link

v3.0.5, added support for ipywidgets>=8.0.0 #169

Closed axil closed 1 year ago

axil commented 1 year ago

Built upon v3.0.4. Fixes #168

philippjfr commented 1 year ago

Thanks for looking at this. It looks good, but has to be rebased unfortunately.

axil commented 1 year ago

@philippjfr Well, technically speaking it should be trivial to rebase as it is just one bump in the dependencies:

  "dependencies": {
-    "@jupyter-widgets/base": "^3 || ^4.0.0",
+    "@jupyter-widgets/base": "^6",

Is the current main branch ready for release?

I've written an article about bokeh but I can't publish it because pip install jupyter_bokeh does not work.

philippjfr commented 1 year ago

@mattpap There's a few people asking for a release now. Any chance we could make this change and then release?

axil commented 1 year ago

@philippjfr I've rebased against main. Now it says "Can't find module core/serialization". But I see the same message on main without my changes, too. Do you know how to deal with it?

axil commented 1 year ago

@philippjfr @mattpap maybe it is possible to release 3.0.5a alpha version without rebasing? And then gradually complete the serialization improvements? Because as of today jupyter_bokeh is not working at all (e.g. examples fail on fresh install of python + pip install jupyter_bokeh) due to the backwards-incompatible changes in v8.0.0 of ipywidgets.

mattpap commented 1 year ago

Now it says "Can't find module core/serialization".

This is because main is updated for bokeh 3.0.

philippjfr commented 1 year ago

Would be nice if we could release a fix here before bokeh 3.0 though.

mattpap commented 1 year ago

Would be nice if we could release a fix here before bokeh 3.0 though.

Sure. I will create a release branch off an earlier commit, merge and release, and then merge back to main.

mattpap commented 1 year ago

I rebased this and updated lock files. @axil, make sure you use npm 8+, so that lock file version is not downgraded. Looks like everything works with bokeh 2.4.