Improve quality of *.ts files

bokeh / jupyter_bokeh

An extension for rendering Bokeh content in JupyterLab notebooks

BSD 3-Clause "New" or "Revised" License

253 stars 48 forks source link

Improve quality of *.ts files #70

Closed mattpap closed 4 years ago

mattpap commented 4 years ago

[x] enable eslint
[x] use stricter tsconfig

mattpap commented 4 years ago

@bryevdv, I'm not sure if you get notifications for this repository. I'm going to merge this soon. Note that though tests all "all green", they actually don't tests much besides if things got built and the extension is loadable by jupyter-lab at all. I have been working on improving testing, but that will happen later on in another PR.

bryevdv commented 4 years ago

I should get notifs now. I will look at this tomorrow. Do you need any help with releasing/publishing?

bryevdv commented 4 years ago

LGTM

mattpap commented 4 years ago

Do you need any help with releasing/publishing?

Not yet, I have bunch of other changes to get merged first.