Closed consideRatio closed 4 years ago
$ python -m jupyterlab.selenium_check /home/travis/miniconda/bin/python: No module named jupyterlab.selenium_check The command "python -m jupyterlab.selenium_check" exited with 1.
If selenium_check
was removed, then we will have to remove this part of the build.
It was renamed, ill update for that when im at my computer! (on mobile now)
Okay! I think I'm happy with the PR as it is given what I know and understand currently.
@consideRatio, thanks for fixing this.
Thanks a bunch @consideRatio, just confirmed that it works for me!
@mattpap my attribution for this contribution was erased from the git history through the way this PR was squashed and merged =/
Very odd, never seen a squash merge do that before.
@consideRatio, it's unfortunate and must be a bug in GitHub. Squash and merge is supposed to preserve the original author and at most should have added me as a co-author. I checked a few recently merged PRs and it seems it's an isolated event.
Looks like a recent (bad) intentional change at GH:
https://twitter.com/andyhayden1/status/1235593402709716992?s=20
I poked Nat Friedman on twitter and a "fix should be deployed today" :D
@consideRatio We very much appreciate your contribution, I know it's a cliche to say that the reward for good work is more work, but please let us know if we we can help you find another good PR for you to submit that will properly credit you.
JupyterLab 2.0.0 is out, and this extension have conflicting dependencies with its core packages. Fixes #88.
Implementation notes
There was some manual changes needed in the code due to the following part in the JupyterLab migration guide: https://jupyterlab.readthedocs.io/en/stable/developer/extension_migration.html#using-session-and-sessioncontext-to-manage-kernel-sessions
I did my best to ensure I didn't get install / build errors, and made a guess on how to fix it. I have not tested this code in a JupyterLab UI yet.
References