search

bokeh / pm

Project Management resources for the Bokeh Organization
1 stars 1 forks source link

vscode workspace was added to the repository #3

Open mattpap opened 2 years ago

mattpap commented 2 years ago

In commit 88b5477e5c63201dcc98cc712ead6f0993938257, which doesn't look like a mistake. Why? I don't see a reason to keep private configuration in the repository. vscode allows to store workspaces outside of a repository.

bryevdv commented 1 year ago

It was not a mistake. I want a place for it to live that is easily clone-able. I can't stress enough that although you consider these to be private configuration, that is an opinion. Many projects offer workspace configurations as a convenience to users/developers as a means to help people get on the same page quickly. I want to do the same for us. I would even like to encourage (or at least mention) the workspace explicitly in the contributor guide, because vscode is by far the most popular IDE and we should meet users where they are. [1]

I am open to other places but I insist that:

Putting it in this repo, specifically, was already my compromise for not putting it in the main repo (which I do think would be preferable), because I know you would object strenuously to that.

[1] I also realize that a vscode workspace configuration may not interest or apply to you, personally. That's fine, not everything has to—you can just ignore it .