search

bokeh / rbokeh

R interface to Bokeh http://hafen.github.io/rbokeh/
Other
313 stars 66 forks source link

BokehJS v0.12 #160

Closed brett-patterson closed 8 years ago

brett-patterson commented 8 years ago

Are there any plans to support BokehJS v0.12? It doesn't seem to work out of the box, so I assumed there were some changes to the JSON spec, but I didn't investigate very thoroughly. I'd be happy to help if this is something you'd like to do.

pdelboca commented 8 years ago

It would be great. Google Maps is no longer working due to API Update. It was fixed in V0.12

hafen commented 8 years ago

Sorry for the delay. My github notifications are going to the wrong mailbox. I started work on a v0.12 branch and got caught up in some other deadlines but will turn focus to this. Addressing the google maps issue is also on the table.

hafen commented 8 years ago

@brett-patterson thanks for offering to help. I have gone through and found what I think to be all the critical changes in the JSON models and I have a very experimental branch working with 0.12 with the api_key added for google maps. I'll be doing more work and testing on it, but if you want to try it out, devtools::install_github("hafen/rbokeh@bokeh0.12").

hafen commented 8 years ago

I've done quite a bit of work and everything seems to be working with 0.12. Grid plots took a lot of work and there were quite a few other little things. I wouldn't mind some help testing it out. If you want to install:

devtools::install_github("bokeh/rbokeh@dev")

Let me know if you see any issues.

brett-patterson commented 8 years ago

Thanks so much for doing this work @hafen. I'll check it out soon and let you know how it goes.