Deploying the system through Ethereum Wallet creates a menagerie of warnings.
The final compilation capable version that I have edited:
pragma solidity ^0.4.4;
// ------------------------------------------------------------------------
// TokenTraderFactory
//
// Decentralised trustless ERC20-compliant token to ETH exchange contract
// on the Ethereum blockchain.
//
// Note that this TokenTrader cannot be used with the Golem Network Token
// directly as the token does not implement the ERC20
// transferFrom(...), approve(...) and allowance(...) methods
//
// History:
// Jan 25 2017 - BPB Added makerTransferAsset(...) and
// makerTransferEther(...)
// Feb 05 2017 - BPB Bug fix in the change calculation for the Unicorn
// token with natural number 1
// Feb 08 2017 - BPB/JL Renamed etherValueOfTokensToSell to
// amountOfTokensToSell in takerSellAsset(...) to
// better describe the parameter
// Added check in createTradeContract(...) to prevent
// GNTs from being used with this contract. The asset
// token will need to have an allowance(...) function.
//
// Enjoy. (c) JonnyLatte & BokkyPooBah 2017. The MIT licence.
// ------------------------------------------------------------------------
// https://github.com/ethereum/EIPs/issues/20
contract ERC20 {
function totalSupply() public constant returns (uint supply);
function balanceOf(address _owner) public constant returns (uint balance);
function transfer(address _to, uint _value) public returns (bool success);
function transferFrom(address _from, address _to, uint _value) public returns (bool success);
function approve(address _spender, uint _value) public returns (bool success);
function allowance(address _owner, address _spender) public constant returns (uint remaining);
event Transfer(address indexed _from, address indexed _to, uint _value);
event Approval(address indexed _owner, address indexed _spender, uint _value);
}
contract Owned {
address public owner;
event OwnershipTransferred(address indexed _from, address indexed _to);
function Owned() public {
owner = msg.sender;
}
modifier onlyOwner {
if (msg.sender != owner) revert();
_;
}
modifier onlyOwnerOrTokenTraderWithSameOwner {
if (msg.sender != owner && TokenTrader(msg.sender).owner() != owner) revert();
_;
}
function transferOwnership(address newOwner) public onlyOwner {
emit OwnershipTransferred(owner, newOwner);
owner = newOwner;
}
}
// contract can buy or sell tokens for ETH
// prices are in amount of wei per batch of token units
contract TokenTrader is Owned {
address public asset; // address of token
uint256 public buyPrice; // contract buys lots of token at this price
uint256 public sellPrice; // contract sells lots at this price
uint256 public units; // lot size (token-wei)
bool public buysTokens; // is contract buying
bool public sellsTokens; // is contract selling
event ActivatedEvent(bool buys, bool sells);
event MakerDepositedEther(uint256 amount);
event MakerWithdrewAsset(uint256 tokens);
event MakerTransferredAsset(address toTokenTrader, uint256 tokens);
event MakerWithdrewERC20Token(address tokenAddress, uint256 tokens);
event MakerWithdrewEther(uint256 ethers);
event MakerTransferredEther(address toTokenTrader, uint256 ethers);
event TakerBoughtAsset(address indexed buyer, uint256 ethersSent,
uint256 ethersReturned, uint256 tokensBought);
event TakerSoldAsset(address indexed seller, uint256 amountOfTokensToSell,
uint256 tokensSold, uint256 etherValueOfTokensSold);
// Constructor - only to be called by the TokenTraderFactory contract
function TokenTrader (
address _asset,
uint256 _buyPrice,
uint256 _sellPrice,
uint256 _units,
bool _buysTokens,
bool _sellsTokens
) public {
asset = _asset;
buyPrice = _buyPrice;
sellPrice = _sellPrice;
units = _units;
buysTokens = _buysTokens;
sellsTokens = _sellsTokens;
emit ActivatedEvent(buysTokens, sellsTokens);
}
// Maker can activate or deactivate this contract's buying and
// selling status
//
// The ActivatedEvent() event is logged with the following
// parameter:
// buysTokens this contract can buy asset tokens
// sellsTokens this contract can sell asset tokens
//
function activate (
bool _buysTokens,
bool _sellsTokens
) public onlyOwner {
buysTokens = _buysTokens;
sellsTokens = _sellsTokens;
emit ActivatedEvent(buysTokens, sellsTokens);
}
// Maker can deposit ethers to this contract so this contract
// can buy asset tokens.
//
// Maker deposits asset tokens to this contract by calling the
// asset's transfer() method with the following parameters
// _to is the address of THIS contract
// _value is the number of asset tokens to be transferred
//
// Taker MUST NOT send tokens directly to this contract. Takers
// MUST use the takerSellAsset() method to sell asset tokens
// to this contract
//
// Maker can also transfer ethers from one TokenTrader contract
// to another TokenTrader contract, both owned by the Maker
//
// The MakerDepositedEther() event is logged with the following
// parameter:
// ethers is the number of ethers deposited by the maker
//
// This method was called deposit() in the old version
//
function makerDepositEther() public payable onlyOwnerOrTokenTraderWithSameOwner {
emit MakerDepositedEther(msg.value);
}
// Maker can withdraw asset tokens from this contract, with the
// following parameter:
// tokens is the number of asset tokens to be withdrawn
//
// The MakerWithdrewAsset() event is logged with the following
// parameter:
// tokens is the number of tokens withdrawn by the maker
//
// This method was called withdrawAsset() in the old version
//
function makerWithdrawAsset(uint256 tokens) public onlyOwner returns (bool) {
emit MakerWithdrewAsset(tokens);
return ERC20(asset).transfer(owner, tokens);
}
// Maker can transfer asset tokens from this contract to another
// TokenTrader contract, with the following parameter:
// toTokenTrader Another TokenTrader contract owned by the
// same owner and with the same asset
// tokens is the number of asset tokens to be moved
//
// The MakerTransferredAsset() event is logged with the following
// parameters:
// toTokenTrader The other TokenTrader contract owned by
// the same owner and with the same asset
// tokens is the number of tokens transferred
//
// The asset Transfer() event is also logged from this contract
// to the other contract
//
function makerTransferAsset(
TokenTrader toTokenTrader,
uint256 tokens
) public onlyOwner returns (bool) {
if (owner != toTokenTrader.owner() || asset != toTokenTrader.asset()) {
revert();
}
emit MakerTransferredAsset(toTokenTrader, tokens);
return ERC20(asset).transfer(toTokenTrader, tokens);
}
// Maker can withdraw any ERC20 asset tokens from this contract
//
// This method is included in the case where this contract receives
// the wrong tokens
//
// The MakerWithdrewERC20Token() event is logged with the following
// parameter:
// tokenAddress is the address of the tokens withdrawn by the maker
// tokens is the number of tokens withdrawn by the maker
//
// This method was called withdrawToken() in the old version
//
function makerWithdrawERC20Token(
address tokenAddress,
uint256 tokens
) public onlyOwner returns (bool) {
emit MakerWithdrewERC20Token(tokenAddress, tokens);
return ERC20(tokenAddress).transfer(owner, tokens);
}
// Maker can withdraw ethers from this contract
//
// The MakerWithdrewEther() event is logged with the following parameter
// ethers is the number of ethers withdrawn by the maker
//
// This method was called withdraw() in the old version
//
function makerWithdrawEther(uint256 ethers) public onlyOwner returns (bool) {
address addr = this;
if (addr.balance >= ethers) {
emit MakerWithdrewEther(ethers);
return owner.send(ethers);
}
}
// Maker can transfer ethers from this contract to another TokenTrader
// contract, with the following parameters:
// toTokenTrader Another TokenTrader contract owned by the
// same owner and with the same asset
// ethers is the number of ethers to be moved
//
// The MakerTransferredEther() event is logged with the following parameter
// toTokenTrader The other TokenTrader contract owned by the
// same owner and with the same asset
// ethers is the number of ethers transferred
//
// The MakerDepositedEther() event is logged on the other
// contract with the following parameter:
// ethers is the number of ethers deposited by the maker
//
function makerTransferEther(
TokenTrader toTokenTrader,
uint256 ethers
) public onlyOwner returns (bool) {
if (owner != toTokenTrader.owner() || asset != toTokenTrader.asset()) {
revert();
}
address addr = this;
if (addr.balance >= ethers) {
emit MakerTransferredEther(toTokenTrader, ethers);
toTokenTrader.makerDepositEther.value(ethers)();
}
}
// Taker buys asset tokens by sending ethers
//
// The TakerBoughtAsset() event is logged with the following parameters
// buyer is the buyer's address
// ethersSent is the number of ethers sent by the buyer
// ethersReturned is the number of ethers sent back to the buyer as
// change
// tokensBought is the number of asset tokens sent to the buyer
//
// This method was called buy() in the old version
//
function takerBuyAsset() public payable {
if (sellsTokens || msg.sender == owner) {
// Note that sellPrice has already been validated as > 0
uint order = msg.value / sellPrice;
// Note that units has already been validated as > 0
uint can_sell = ERC20(asset).balanceOf(address(this)) / units;
uint256 change = 0;
if (msg.value > (can_sell * sellPrice)) {
change = msg.value - (can_sell * sellPrice);
order = can_sell;
}
if (change > 0) {
if (!msg.sender.send(change)) revert();
}
if (order > 0) {
if (!ERC20(asset).transfer(msg.sender, order * units)) revert();
}
emit TakerBoughtAsset(msg.sender, msg.value, change, order * units);
}
// Return user funds if the contract is not selling
else if (!msg.sender.send(msg.value)) revert();
}
// Taker sells asset tokens for ethers by:
// 1. Calling the asset's approve() method with the following parameters
// _spender is the address of this contract
// _value is the number of tokens to be sold
// 2. Calling this takerSellAsset() method with the following parameter
// etherValueOfTokens is the ether value of the asset tokens to be sold
// by the taker
//
// The TakerSoldAsset() event is logged with the following parameters
// seller is the seller's address
// amountOfTokensToSell is the amount of the asset tokens being
// sold by the taker
// tokensSold is the number of the asset tokens sold
// etherValueOfTokensSold is the ether value of the asset tokens sold
//
// This method was called sell() in the old version
//
function takerSellAsset(uint256 amountOfTokensToSell) public {
if (buysTokens || msg.sender == owner) {
// Maximum number of token the contract can buy
// Note that buyPrice has already been validated as > 0
address addr = this;
uint256 can_buy = addr.balance / buyPrice;
// Token lots available
// Note that units has already been validated as > 0
uint256 order = amountOfTokensToSell / units;
// Adjust order for funds available
if (order > can_buy) order = can_buy;
if (order > 0) {
// Extract user tokens
if (!ERC20(asset).transferFrom(msg.sender, address(this), order * units)) revert();
// Pay user
if (!msg.sender.send(order * buyPrice)) revert();
}
emit TakerSoldAsset(msg.sender, amountOfTokensToSell, order * units, order * buyPrice);
}
}
// Taker buys tokens by sending ethers
function () public payable {
takerBuyAsset();
}
}
// This contract deploys TokenTrader contracts and logs the event
contract TokenTraderFactory is Owned {
event TradeListing(address indexed ownerAddress, address indexed tokenTraderAddress,
address indexed asset, uint256 buyPrice, uint256 sellPrice, uint256 units,
bool buysTokens, bool sellsTokens);
event OwnerWithdrewERC20Token(address indexed tokenAddress, uint256 tokens);
mapping(address => bool) _verify;
// Anyone can call this method to verify the settings of a
// TokenTrader contract. The parameters are:
// tradeContract is the address of a TokenTrader contract
//
// Return values:
// valid did this TokenTraderFactory create the TokenTrader contract?
// owner is the owner of the TokenTrader contract
// asset is the ERC20 asset address
// buyPrice is the buy price in ethers per `units` of asset tokens
// sellPrice is the sell price in ethers per `units` of asset tokens
// units is the number of units of asset tokens
// buysTokens is the TokenTrader contract buying tokens?
// sellsTokens is the TokenTrader contract selling tokens?
//
function verify(address tradeContract) public constant returns (
bool valid,
address owner,
address asset,
uint256 buyPrice,
uint256 sellPrice,
uint256 units,
bool buysTokens,
bool sellsTokens
) {
valid = _verify[tradeContract];
if (valid) {
TokenTrader t = TokenTrader(tradeContract);
owner = t.owner();
asset = t.asset();
buyPrice = t.buyPrice();
sellPrice = t.sellPrice();
units = t.units();
buysTokens = t.buysTokens();
sellsTokens = t.sellsTokens();
}
}
// Maker can call this method to create a new TokenTrader contract
// with the maker being the owner of this new contract
//
// Parameters:
// asset is the ERC20 asset address
// buyPrice is the buy price in ethers per `units` of asset tokens
// sellPrice is the sell price in ethers per `units` of asset tokens
// units is the number of units of asset tokens
// buysTokens is the TokenTrader contract buying tokens?
// sellsTokens is the TokenTrader contract selling tokens?
//
// For example, listing a TokenTrader contract on the REP Augur token where
// the contract will buy REP tokens at a rate of 39000/100000 = 0.39 ETH
// per REP token and sell REP tokens at a rate of 41000/100000 = 0.41 ETH
// per REP token:
// asset 0x48c80f1f4d53d5951e5d5438b54cba84f29f32a5
// buyPrice 39000
// sellPrice 41000
// units 100000
// buysTokens true
// sellsTokens true
//
// The TradeListing() event is logged with the following parameters
// ownerAddress is the Maker's address
// tokenTraderAddress is the address of the newly created TokenTrader contract
// asset is the ERC20 asset address
// buyPrice is the buy price in ethers per `units` of asset tokens
// sellPrice is the sell price in ethers per `units` of asset tokens
// unit is the number of units of asset tokens
// buysTokens is the TokenTrader contract buying tokens?
// sellsTokens is the TokenTrader contract selling tokens?
//
function createTradeContract(
address asset,
uint256 buyPrice,
uint256 sellPrice,
uint256 units,
bool buysTokens,
bool sellsTokens
) public returns (address trader) {
// Cannot have invalid asset
if (asset == 0x0) revert();
// Check for ERC20 allowance function
// This will revert() an error if the allowance function
// is undefined to prevent GNTs from being used
// with this factory
ERC20(asset).allowance(msg.sender, this);
// Cannot set zero or negative price
if (buyPrice <= 0 || sellPrice <= 0) revert();
// Must make profit on spread
if (buyPrice >= sellPrice) revert();
// Cannot buy or sell zero or negative units
if (units <= 0) revert();
trader = new TokenTrader(
asset,
buyPrice,
sellPrice,
units,
buysTokens,
sellsTokens);
// Record that this factory created the trader
_verify[trader] = true;
// Set the owner to whoever called the function
TokenTrader(trader).transferOwnership(msg.sender);
emit TradeListing(msg.sender, trader, asset, buyPrice, sellPrice, units, buysTokens, sellsTokens);
}
// Factory owner can withdraw any ERC20 asset tokens from this contract
//
// This method is included in the case where this contract receives
// the wrong tokens
//
// The OwnerWithdrewERC20Token() event is logged with the following
// parameter:
// tokenAddress is the address of the tokens withdrawn by the maker
// tokens is the number of tokens withdrawn by the maker
//
function ownerWithdrawERC20Token(address tokenAddress, uint256 tokens) public onlyOwner returns (bool) {
emit OwnerWithdrewERC20Token(tokenAddress, tokens);
return ERC20(tokenAddress).transfer(owner, tokens);
}
// Prevents accidental sending of ether to the factory
function () public {
revert();
}
}
Deploying the system through Ethereum Wallet creates a menagerie of warnings.
The final compilation capable version that I have edited: