No critical issue, bug fixing is necessary. It is highly recommended to complete a bug bounty before use.
Medium severity issues:
If attacker creates smart contract with '''owner''' variable equal to real owner address and '''asset''' variable equal to real asset there is a risk of send money to this wrong address.
Low severity issues:
The modifier onlyOwnerOrTokenTraderWithSameOwner allows attacker to run function code if it calls form smart contract with '''owner''' variable equal to real owner address. In this contract it can not cause a loss of customers funds or a breach of contracts operability, but you need to be aware of this in future use.
TokenTrader Smart Contract security audit report performed by Callisto Security Audit Department
Conclusion:
No critical issue, bug fixing is necessary. It is highly recommended to complete a bug bounty before use.
Medium severity issues:
Low severity issues:
The modifier onlyOwnerOrTokenTraderWithSameOwner allows attacker to run function code if it calls form smart contract with '''owner''' variable equal to real owner address. In this contract it can not cause a loss of customers funds or a breach of contracts operability, but you need to be aware of this in future use.
Overflowing is possible if Maker (seller) set UNREAL HIGH sellPrice.
Full audit report is here.