search

bokkypoobah / TokenTrader

TokenTrader And TokenSeller Decentralised Trustless Exchange Contract
https://cryptoderivatives.market/
MIT License
145 stars 50 forks source link

Bad jump destination #9

Closed maxnachamkin closed 7 years ago

maxnachamkin commented 7 years ago

I'm attempting to create a TokenTraderFactory contract for an ERC20 token I created using TokenFactory, but keep getting 'bad jump destination' when I publish.

I've tried increasing the gas, and verified the parameters for the constructor.

Any ideas?

See transaction here: https://ropsten.etherscan.io/tx/0xd98f0ea5ae209e425333f77568ba0facb3161d9c801ccf63fbfb74df87e8002d

bokkypoobah commented 7 years ago

From your transaction, the buyPrice is set to be the same as the sellPrice - this will cause an exception:

Function: createTradeContract(address asset, uint256 buyPrice, uint256 sellPrice, uint256 units, bool buysTokens, bool sellsTokens)

MethodID: 0x3d6a32bd
[0]:000000000000000000000000ca5db8db2c292b6f6fcc93289eefc31f542df65d
[1]:000000000000000000000000000000000000000000000000000000000000012b
[2]:000000000000000000000000000000000000000000000000000000000000012b
[3]:00000000000000000000000000000000000000000000000000000000000f41dc
[4]:0000000000000000000000000000000000000000000000000000000000000001
[5]:0000000000000000000000000000000000000000000000000000000000000001
maxnachamkin commented 7 years ago

Awesome, that worked. Thank you!