search

bokmann / font-awesome-rails

the font-awesome font bundled as an asset for the rails asset pipeline
http://fortawesome.github.com/Font-Awesome/
MIT License
1.86k stars 244 forks source link

Tests appear to fail with Ruby 3 #213

Closed snecklifter closed 3 years ago

snecklifter commented 3 years ago

Fedora is upgrading to Ruby 3.0 and the following error is generated when running tests:

/usr/share/gems/gems/sprockets-rails-3.2.2/lib/sprockets/railtie.rb:106:in `block in <class:Railtie>': Expected to find a manifest file in `app/assets/config/manifest.js` (Sprockets::Railtie::ManifestNeededError)
But did not, please create this file and use it to link any assets that need
to be rendered by your app:

Example:
  //= link_tree ../images
  //= link_directory ../javascripts .js
  //= link_directory ../stylesheets .css
and restart your server

For more information see: https://github.com/rails/sprockets/blob/070fc01947c111d35bb4c836e9bb71962a8e0595/UPGRADING.md#manifestjs

Any ideas on how to resolve would be appreciated.

rmm5t commented 3 years ago

This sounds like more of a Rails and Sprockets issue than a Ruby 3 issue. The dummy app in the tests would benefit from a manifest file if there isn’t one currently. I’m away from a big keyboard at the moment, but a PR would be very much appreciated in the meantime.

rmm5t commented 3 years ago

@snecklifter v4.7.0.7 should fix this issue. It was just released.