search

boknows / cFIREsim-open

An attempt to re-write the popular retirement calculator (cFIREsim.com) in mainly javascript, and begin the journey toward open-source.
Apache License 2.0
154 stars 52 forks source link

Implement "tabs" for output graphs #20

Closed boknows closed 9 years ago

boknows commented 9 years ago

In the legacy cFIREsim, every new simulation creates a new browser tab. This allows for easy comparison between multiple similar simulations. With the new javascript code, I believe that it is inconveinient to open a new tab and pass along the data, which is why I opted for a pop-up window. However, this makes it hard to compare simulations, because you can't easily open multiple simulations at once.

We either need to implement some psuedo-tabs in the output pop-up, or re-implement the legacy version by sending the data to a new tab.

jchristian commented 9 years ago

I know there is quite a bit of information, but would it be possible to pass the simulation parameters through the URL? Would make this request fairly trivial and allow easy saving of simulations.

boknows commented 9 years ago

I'm pretty close to implementing pseudo tabs inside a modal pop-up, so this will be moot soon. On Aug 13, 2015 4:16 PM, "Jonathan Christian" notifications@github.com wrote:

I know there is quite a bit of information, but would it be possible to pass the simulation parameters through the URL? Would make this request fairly trivial and allow easy saving of simulations.

— Reply to this email directly or view it on GitHub https://github.com/boknows/cFIREsim-open/issues/20#issuecomment-130827166 .

boknows commented 9 years ago

Added in https://github.com/boknows/cFIREsim-open/commit/5b1541e2e07db1dc60dc919894e0880f19555ad1