boku-ilen / geodot-plugin

Godot plugin for loading geospatial data
GNU General Public License v3.0
109 stars 19 forks source link

geodot crashes godot #24

Closed chrisgraf closed 3 years ago

chrisgraf commented 4 years ago
2020-05-24_01-35-08-427 [ERR ] [main] Phytocoenosis CSV file does not exist, expected it at vegetation/phytocoenosis.csv
ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.
ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x46210) [0x7f36193af210] (??:0)
[2] GeoRaster::get_as_array() (??:0)
[3] GeoRaster::get_histogram() (??:0)
[4] GeoRaster::get_most_common(int) (??:0)
[5] godot::GeoImage::get_most_common(int) (??:0)
[6] godot_variant godot::__wrapped_method<godot::GeoImage, godot::Array, int>(void*, void*, void*, int, godot_variant**) (??:0)
[7] ../Godot_v3.2.1-stable_x11.64() [0x25cab97] (<artificial>:?)
kb173 commented 4 years ago
ERROR: Geodot::get_image: No valid data was available for the requested path and position!
   At: geodot.cpp:26.

This always hints at missing data or invalid paths. The subsequent crashes are caused by trying to access this data.

I'm assuming this happened in the LandscapeLab and the geodata path is incorrect, since the phytocoenosis CSV file could also not be found (first error). I'm assuming it may be related to https://github.com/boku-ilen/landscapelab/commit/82f36359dc4f3ee50dca123485fc422096d3af16? (But this issue should be moved to the LandscapeLab if it's related to the geopackage restructure)

chrisgraf commented 4 years ago

I know the file is missing. my point is: it still must not crash the engine but return back an "exception"-equivalent, which can be handled by the calling code

chrisgraf commented 4 years ago

and yes, this commit should not have been pushed yet, sorry

kb173 commented 3 years ago

26 describes the specific issue left to fix here.