bokuanT / pe

0 stars 0 forks source link

Duplicate keydates allowed #7

Open bokuanT opened 1 year ago

bokuanT commented 1 year ago

image.png

might be confusing for users who accidentally added duplicates

nus-pe-bot commented 1 year ago

Team's Response

Firstly, it is entirely possible for multiple of the same events to happen on the same date (eg. these days onsite interviews can have multiple rounds on the same day). Hence, users will have the freedom to add multiple of the same keydates. It should have been understood.

Secondly, if you read the Developer Guide, you'd realise that under Planned Enhancement #2, we plan to add time into our keydates. This is part of the future enhancement, so it is entirely irrelevant.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicate Keydates are allowed in an opening

Duplicate keydates (identical keys and dates) are allowed in each opening, as shown in the screenshot below.

Screenshot 2023-04-14 at 2.27.47 PM.png

This can lead to confusion among the users as they might be unsure whether the duplicate was added as a mistake or as intended. Each keydate also does not contain any information that can help differentiate duplicates, if the duplicate was intended.

The behaviour of duplicate keydates was not specified in the user guide.


[original: nus-cs2103-AY2223S2/pe-interim#2685] [original labels: type.FunctionalityBug severity.Medium]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Firstly, it is entirely possible for multiple of the same events to happen on the same date (eg. these days onsite interviews can have multiple rounds on the same day). Hence, users will have the freedom to add multiple of the same keydates. It should have been understood.

Secondly, if you read the Developer Guide, you'd realise that under Planned Enhancement #2, we plan to add time into our keydates. This is part of the future enhancement, so it is entirely irrelevant.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** Even if the enhancement is taken into consideration, users are allowed to add keydates without time so the issue as mentioned below can still occur, making the functionalilty of keeping track of keydates accurately less useful.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** [replace this with your reason] ![image.png](https://raw.githubusercontent.com/bokuanT/pe/main/files/f832fbea-193d-4024-8c51-d6be461e5ace.png) Users are unable to distinguish between accidental and intended duplicate keydates, especially if they use the product between long periods. This hinders the product's purpose of allowing users to keep track of all important information about an internship application.
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]