search

bokub / vanity-eth

💎 Browser-based ETH vanity address generator
https://vanity-eth.tk
MIT License
741 stars 264 forks source link

private key security #44

Closed hcocoa closed 2 years ago

hcocoa commented 2 years ago

Just read about profanity incident.

Please check https://github.com/bokub/vanity-eth/blob/620a2c198010ccf56e8f60baccbf94ed74b15bf6/src/js/vanity.js#L21

Does this project have the similar problem? Is 32 bytes enough for a private key?

bokub commented 2 years ago

Does this project have the similar problem?

No, it doesn't have a similar problem

Is 32 bytes enough for a private key?

32 bytes is literally the size of a Ethereum private key, so yes, it's enough and could not be higher even if I wanted to.

Profanity uses 32 bit seeds, which is the same as 4 bytes.

Please read #43 for more details

hcocoa commented 2 years ago

thanks for the reply

Favourjacobmudiaga commented 1 year ago

Good