A couple of tweaks for get-ncbi-data

bokulich-lab / RESCRIPt

REference Sequence annotation and CuRatIon Pipeline

BSD 3-Clause "New" or "Revised" License

85 stars 26 forks source link

A couple of tweaks for get-ncbi-data #101

Closed BenKaehler closed 3 years ago

BenKaehler commented 3 years ago

Fixed get-ncbi-data so that it now accommodates the oddness evident in the download that resulted from this query.

Added a unit test.

Unfortunately NCBI has fixed a couple of things that were broken before, so I had to loosen one unit test.

BenKaehler commented 3 years ago

The ci errors on this should resolve after #102 goes in. Thanks @mikerobeson!

misialq commented 3 years ago

Hey @BenKaehler, I'm about to release version 2021.4: do you think you could update this PR with the latest changes to fix the CI before I do that? We could also merge it after - I just thought that it all works and it's only a matter of bringing the PR up-to-date. Thanks!