search

bokulich-lab / RESCRIPt

REference Sequence annotation and CuRatIon Pipeline
BSD 3-Clause "New" or "Revised" License
85 stars 26 forks source link

removal of RESCRIPt RNA types, etc.. #102

Closed mikerobeson closed 3 years ago

mikerobeson commented 3 years ago

As RNA types, formats, and transformers have been added to base QIIME 2 as of PR (qiime2/q2-types#256), this created problems with RESCRIPt's own RNA types. This PR removes all RESCRIPt RNA types and uses the new base QIIME 2 RNA types. Some transformers (i.e. RNA -> DNA) in RESCRIPt that should be migrated over to q2-types. But I left them alone for now.

All unit tests and flake8 checks pass. I've also installed these PR changes into my qiime2-dev environment w/o warnings of duplicated types, etc...

BenKaehler commented 3 years ago

Thank you @mikerobeson and @misialq!

@mikerobeson, could you please update the readme to say that the minimum qiime version is now 2021.4?

@misialq, do not merge! until after the 2021.4 release. (I’m sure you knew that already, but best to be explicit.)