bokulich-lab / RESCRIPt

REference Sequence annotation and CuRatIon Pipeline
BSD 3-Clause "New" or "Revised" License
85 stars 26 forks source link

drop experimental loo cv method #130

Closed nbokulich closed 2 years ago

nbokulich commented 2 years ago

there is an experimental loo cv method that was never exposed as an action.

this pulls some functions from q2-feature-classifier that are being cut out in this PR: https://github.com/qiime2/q2-feature-classifier/pull/176

so I propose just dropping this function in rescript for now. We can always add back later if anyone wants... does that sound reasonable @mikerobeson ?

mikerobeson commented 2 years ago

Sounds good to me @nbokulich. I can merge if there is nothing else to modify.

nbokulich commented 2 years ago

thanks! nothing else needed IMO, ready to merge. I can open an issue to "bookmark" this for a possible later date.