search

bokulich-lab / RESCRIPt

REference Sequence annotation and CuRatIon Pipeline
BSD 3-Clause "New" or "Revised" License
84 stars 26 forks source link

MAINT: Add future deprecation warning for orient-seqs #150

Closed mirand863 closed 1 year ago

mirand863 commented 1 year ago

This PR adds a future deprecation warning for the parameters perc_identity, query_cov and left_justify in the function orient-seqs. See PR #149 for more details.

nbokulich commented 1 year ago

Thanks @mirand863 ! Looks great. You marked this as a draft PR but I think that we can merge whenever you are ready.

mirand863 commented 1 year ago

Thanks @mirand863 ! Looks great. You marked this as a draft PR but I think that we can merge whenever you are ready.

@nbokulich,

Thank you for reviewing this PR! Would you like me to specify a version where these parameters will be removed? Otherwise it is good to merge from my side as well.

nbokulich commented 1 year ago

Hi @mirand863 , Sure, you could say that these parameters will be removed in the 2023.5 release. 2023.2 will be the last release with these parameters. Thanks!

mirand863 commented 1 year ago

Done!