bokulich-lab / RESCRIPt

REference Sequence annotation and CuRatIon Pipeline
BSD 3-Clause "New" or "Revised" License
84 stars 26 forks source link

FIX: update `get-ncbi-genomes` to use genome accession IDs as taxonomy IDs #193

Closed misialq closed 1 week ago

misialq commented 3 weeks ago

This PR fixes the issue where the taxonomies generated by the get-ncbi-genomes action would contain IDs that do not match the IDs used in the corresponding FASTA file to represent genomic sequences.

misialq commented 1 week ago

Hey @nbokulich, thanks for review! I removed the README file - the zip one had already been removed (you meant the one in the tests/data dir, right?)

nbokulich commented 1 week ago

Hey @misialq I did a bit of user testing with my favorite taxa and all LGTM, thanks!

Yes you are right, I was not reading carefully enough. I now see that this PR removes the unwanted file.

misialq commented 1 week ago

Hey @nbokulich, thanks a lot for testing! In that case, I'm merging this with great excitement 😆