bokulich-lab / q2-assembly

QIIME 2 plugin for (meta)genome assembly.
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

BUG: fix phred-offset autodetection #57

Closed misialq closed 1 year ago

misialq commented 1 year ago

Closes #55. Closes #56.

codecov[bot] commented 1 year ago

Codecov Report

Merging #57 (d000da9) into main (e9c9bd3) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   98.44%   98.45%   +0.01%     
==========================================
  Files          25       25              
  Lines        1353     1363      +10     
==========================================
+ Hits         1332     1342      +10     
  Misses         21       21              
Files Coverage Δ
q2_assembly/_action_params.py 100.00% <ø> (ø)
q2_assembly/spades/spades.py 100.00% <100.00%> (ø)
q2_assembly/spades/tests/test_spades.py 99.10% <100.00%> (+0.06%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

mikerobeson commented 1 year ago

Hi @misialq, #56 appears to work as it should. I've been able to successfully run assemble-spades when I either explicitly set --p-phred-offset 'auto-detect', or just let it use the default to run 'auto-detect'. Also, the help text update for #55 looks goo to me. I think this is ready to merge. 👍

misialq commented 1 year ago

Great, thanks for testing so quickly @mikerobeson!