search

bokulich-lab / q2-assembly

QIIME 2 plugin for (meta)genome assembly.
BSD 3-Clause "New" or "Revised" License
4 stars 12 forks source link

FIX: pass BAM files to metaquast in the correct order #90

Closed misialq closed 2 months ago

misialq commented 4 months ago

The BAM file paths passed to the metaQUAST command (if provided) have the wrong order - they need to be sorted so that the order matches the order of the contig files.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (d8fe338) to head (041c5d3). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #90 +/- ## ======================================= Coverage 98.37% 98.38% ======================================= Files 39 39 Lines 2528 2534 +6 ======================================= + Hits 2487 2493 +6 Misses 41 41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DorielaGrabocka commented 2 months ago

Tests pass, the command passes the BAM files in the same order as contigs.

DorielaGrabocka commented 2 months ago

Only issue, coverage below threshold.